dekaf: Generate predictable shard IDs for dekaf materialization endpoints #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
commented
Jan 2, 2025
| @@ -6,6 +6,16 @@ on: | |||
| paths: | |||
| - "crates/dekaf/**" | |||
| - "crates/proto-**" | |||
| - "crates/allocator" | |||
There was a problem hiding this comment.
I think I'm coming around to the idea that Dekaf should just be another binary in the flow image, as opposed to its own image. But for the moment, this just has it rebuild when any of its local crate deps change
psFried
approved these changes
Jan 2, 2025
| @@ -327,7 +327,22 @@ async fn walk_materialization( | |||
| { | |||
| shard_template.id.clone() | |||
| } else { | |||
| assemble::shard_id_prefix(pub_id, materialization, labels::TASK_TYPE_MATERIALIZATION) | |||
| assemble::shard_id_prefix( | |||
| match endpoint { | |||
There was a problem hiding this comment.
optional nit: feel free to disagree, but I found this inlined match expression to be a little hard on the eyes, and would I think prefer a variable.
…ints For UX reasons, we only want to use the task name (`myTenant/materializations/dekaf`) when authenticating to Dekaf, as opposed to the full shard template ID (`/myTenant/materializations/dekaf/0fa42cafc58003fa`). The agent API's `/authorize/task` expects to be passed the full shard template ID, so since Dekaf materializations never actually create any shards, we decided to use a fixed value for the pub ID component, allowing Dekaf to craft the correct shard template ID given only the task name.
jshearer
force-pushed
the
jshearer/dekaf_validation_update
branch
from
3a188cc to
fe4f57c
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UX reasons, we only want to use the task name (
myTenant/materializations/dekaf) when authenticating to Dekaf, as opposed to the full shard template ID (/myTenant/materializations/dekaf/0fa42cafc58003fa).OTOH, the agent API's
/authorize/taskendpoint expects to be passed the full shard template ID, so since Dekaf materializations never actually create any shards, we decided to use a fixed value for the pub ID component, allowing Dekaf to craft the correct shard template ID given only the task name.Cherry-picked out of #1840, as it's required to test Dekaf materialization functionality e2e
This change is