gazette: Implement journal::append()
#1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
force-pushed
the
jshearer/gazette_appends
branch
from
aa21266 to
fb318a8
Compare
jgraettinger
requested changes
Jan 9, 2025
jshearer
force-pushed
the
jshearer/gazette_appends
branch
from
cc7c66f to
47804cd
Compare
jshearer
changed the title
append_stream and friendsjournal::append()
|
Alright @jgraettinger, want to take another look? |
jshearer
commented
Jan 10, 2025
jshearer
force-pushed
the
jshearer/gazette_appends
branch
from
47804cd to
0e076da
Compare
jgraettinger
approved these changes
Jan 14, 2025
This implements low-level appends to Gazette. It takes a function that generates a stream of `Bytes`, and attempts to drive an append RPC. If the RPC errors, you can retry by re-polling after recieving an Error.
jshearer
force-pushed
the
jshearer/gazette_appends
branch
from
0e076da to
84b6437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This implements low-level appends to Gazette. It takes a function that generates a stream of
Bytes, and attempts to drive an append RPC. If the RPC errors, you can retry by re-polling after recieving an Error.Pulled out of my Dekaf work in #1840 for better reviewability.
This change is