Expose resource pointers and resource config update through flow-web crate
#1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use and expose in flow-eb
Cleaning up imports
travjenkins
commented
Jan 14, 2025
Comment on lines
+210
to
+212
| // Outputting as a string as I just could NOT get it to return JSON correctly | ||
| let output = serde_json::to_string(&resource_spec).unwrap(); | ||
| serde_wasm_bindgen::to_value(&{ output }).map_err(|err| JsValue::from_str(&format!("{err:?}"))) |
There was a problem hiding this comment.
I quit trying to get this to return a JSON object to JS and just returned a string and parse it in the JS.
I kept getting the Value back (map of key values) and got frustrated and stopped trying.
travjenkins
commented
Jan 22, 2025
| @@ -233,6 +233,42 @@ fn test_end_to_end_extend_read_bundle() { | |||
| ); | |||
| } | |||
|
|
|||
| #[wasm_bindgen_test] | |||
There was a problem hiding this comment.
For sure does not cover everything and is really more of a happy path test. Did not feel like writing every permutation with this or that property missing was necessary right now.
travjenkins
changed the title
flow-web crate
9 tasks
…nctions-from-agent-for-wasm
Making this a default feature causes it to be enabled when building the `flow-web` crate, even with `default-features = false`. So removing combine from default features and making other dependents explicitly enable it, to try to get flow-web building.
Fixes a regression in how we generate resource configs when adding bindings to a materialization. This regressed as part of introducing the ability to specify the target schema as part of the `sourceCapture` configuration. When adding a binding to a materialization that uses `targetSchema: fromSourceName`, if the resource spec schema includes an `x-schema-name` annotation, then we'll only use the last path component of the collection name to set `x-collection-name`. But if the materialization uses `targetSchema: leaveEmpty`, or if the resource spec schema does not include an `x-schema-name` annotation, then we'll use the concatenation of the last two path components of the collection name, just like we used to.
mdibaiee
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
#1760
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Related UI task
This change is