Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema.org to dataset #708

Closed
wants to merge 1 commit into from
Closed

Add schema.org to dataset #708

wants to merge 1 commit into from

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Aug 23, 2018

No description provided.

@tusbar tusbar added this to the 3.8.0 milestone Aug 23, 2018
@tusbar tusbar self-assigned this Aug 23, 2018
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-708 August 23, 2018 15:29 Inactive
@buildsize
Copy link

buildsize bot commented Aug 23, 2018

File name Previous Size New Size Change
page-_error.js.gz 164 bytes 164 bytes 0 bytes (0%)
page-catalog.js.gz 56.4 KB 56.41 KB 2 bytes (0%)
page-catalogs.js.gz 3.61 KB 3.61 KB 0 bytes (0%)
page-dataset.js.gz 18.49 KB 18.97 KB 495 bytes (3%)
page-doc-publish-your-data.js.gz 3.71 KB 3.71 KB 0 bytes (0%)
page-doc.js.gz 1.86 KB 1.86 KB 0 bytes (0%)
page-events.js.gz 2.35 KB 2.35 KB 0 bytes (0%)
page-harvest.js.gz 2.98 KB 2.98 KB 0 bytes (0%)
page-index.js.gz 5.85 KB 5.85 KB 2 bytes (0%)
page-legal.js.gz 818 bytes 818 bytes 0 bytes (0%)
page-publication-datasets.js.gz 5.96 KB 5.96 KB -6 bytes (0%)
page-publication-organization.js.gz 9.25 KB 9.25 KB -1 bytes (0%)
page-publication-producers.js.gz 5.46 KB 5.46 KB 0 bytes (0%)
page-publication.js.gz 3.81 KB 3.81 KB 0 bytes (0%)
page-search.js.gz 7.68 KB 7.69 KB 13 bytes (0%)
page-doc-link-proxy.js.gz 1.46 KB 1.46 KB 0 bytes (0%)
page-embed-preview.js.gz 4.51 KB 4.52 KB 10 bytes (0%)
chunk-dataset_downloads_preview_table.js.gz 12.59 KB 12.59 KB 0 bytes (0%)
page-_app.js.gz 2.77 KB 2.77 KB 0 bytes (0%)
static-commons-main-[hash].js.gz 133.22 KB 133.26 KB 44 bytes (0%)
chunk-centered_map_map.js.gz 169.7 KB 169.7 KB 0 bytes (0%)

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #708 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #708      +/-   ##
=========================================
- Coverage    5.27%   5.22%   -0.05%     
=========================================
  Files         113     114       +1     
  Lines        1498    1511      +13     
=========================================
  Hits           79      79              
- Misses       1419    1432      +13
Impacted Files Coverage Δ
lib/schema-org/dataset.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7397d...8df71db. Read the comment docs.

@tusbar tusbar force-pushed the tusbar/schema-org branch from 2bfc0bf to 43e937c Compare August 27, 2018 14:49
@tusbar tusbar temporarily deployed to geodatagouv-pr-708 August 27, 2018 14:49 Inactive
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-708 September 4, 2018 09:32 Inactive
@tusbar
Copy link
Contributor Author

tusbar commented Sep 6, 2018

@jdesboeufs Vu qu’on fetch pas le producteur server side sur data.gouv.fr, je peux pas l’indiquer dans le dataset.

cf #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants