Upgrade to Go 1.12 (tests) #10528
Assignees
Labels
Comments
spzala
added a commit
to spzala/etcd
that referenced
this issue
Apr 5, 2019
Update to go 1.12 testing. Fixes etcd-io#10528
spzala
added a commit
to spzala/etcd
that referenced
this issue
Apr 5, 2019
Update to go 1.12.2 testing. Fixes etcd-io#10528
spzala
pushed a commit
to spzala/etcd
that referenced
this issue
Apr 11, 2019
Update to Go 1.12.2 testing. Remove deprecated unused and gosimple pacakges, and mask staticcheck 1006. Related etcd-io#10528 etcd-io#10438 Co-Authored-By: Gyuho Lee <[email protected]>
spzala
pushed a commit
to spzala/etcd
that referenced
this issue
Apr 25, 2019
Update to Go 1.12.2 testing. Remove deprecated unused and gosimple pacakges, and mask staticcheck 1006. Related etcd-io#10528 etcd-io#10438 Co-Authored-By: Gyuho Lee <[email protected]>
spzala
pushed a commit
to spzala/etcd
that referenced
this issue
May 2, 2019
Update to Go 1.12.2 testing. Remove deprecated unused and gosimple pacakges, and mask staticcheck 1006. Related etcd-io#10528 etcd-io#10438 Co-Authored-By: Gyuho Lee <[email protected]>
spzala
pushed a commit
to spzala/etcd
that referenced
this issue
Jun 4, 2019
Update to Go 1.12.2 testing. Remove deprecated unused and gosimple pacakges, and mask staticcheck 1006. Related etcd-io#10528 etcd-io#10438 Co-Authored-By: Gyuho Lee <[email protected]>
spzala
pushed a commit
to spzala/etcd
that referenced
this issue
Jun 5, 2019
Update to Go 1.12.5 testing. Remove deprecated unused and gosimple pacakges, and mask staticcheck 1006. Also, fix unconvert errors related to unnecessary type conversions and following staticcheck errors: - remove redundant return statements - use for range instead of for select - use time.Since instead of time.Now().Sub - omit comparison to bool constant - replace T.Fatal and T.Fatalf in tests with T.Error and T.Fatalf respectively because the goroutine calls T.Fatal must be called in the same goroutine as the test - fix error strings that should not be capitalized - use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...)) - use he status code of Canceled instead of grpc.ErrClientConnClosing which is deprecated - use use status.Errorf instead of grpc.Errorf which is deprecated Related etcd-io#10528 etcd-io#10438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/cc @hexfusion @spzala
The text was updated successfully, but these errors were encountered: