Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bill-of-materials test fails in CI with Go 1.13 #11132

Closed
gyuho opened this issue Sep 6, 2019 · 14 comments · Fixed by #11151
Closed

bill-of-materials test fails in CI with Go 1.13 #11132

gyuho opened this issue Sep 6, 2019 · 14 comments · Fixed by #11151

Comments

@gyuho
Copy link
Contributor

gyuho commented Sep 6, 2019

#11110

Checking bill of materials...

2019/09/06 19:56:12 open /go/pkg/mod/github.com/beorn7/[email protected]/src/github.com/beorn7/perks/quantile: no such file or directory

1,456d0

< [
@gyuho
Copy link
Contributor Author

gyuho commented Sep 6, 2019

@spzala @vimalk78 Can you help on this?

@vimalk78
Copy link
Contributor

vimalk78 commented Sep 6, 2019

sure, i can take a look.

@vimalk78
Copy link
Contributor

vimalk78 commented Sep 8, 2019

@gyuho , this requires modifications in https://github.com/coreos/license-bill-of-materials
Tested with local changes, and it works.

Should i send a PR to https://github.com/coreos/license-bill-of-materials or fork it as part of https://github.com/etcd-io and fix that?

@gyuho
Copy link
Contributor Author

gyuho commented Sep 9, 2019

Let's fix coreos/license-bill-of-materials, and etcd will automatically pick up the latest.

@vimalk78
Copy link
Contributor

vimalk78 commented Sep 9, 2019

ok !!

@vimalk78 vimalk78 mentioned this issue Sep 9, 2019
Merged
vimalk78 added a commit to vimalk78/license-bill-of-materials that referenced this issue Sep 9, 2019
@vimalk78
*: Modified to conform to Module aware 'go list'
ae365cb 
Go 1.13 is module aware, so the output of 'go list' results in paths pointing to moule cache (GOPATH/pkg/mod).
Non module aware go versions, the `Root` field in the `go list` output contained `GOPATH`. IN module aware Go versions, it points to the root of module in module cache.
Earlier versions, the LICENSEs could be read by concatenating the concatenating `GOPATH` and `ImportPath`. Now the LICENSES need to be read using `Root` and `Dir` fields which point to the root of the module and imported folder within the module.

This change fixes bill-of-materials test fails in CI with Go 1.13.
etcd-io/etcd#11132
vimalk78 added a commit to vimalk78/license-bill-of-materials that referenced this issue Sep 9, 2019
@vimalk78
*: Modified to conform to Module aware 'go list'
4b38636 
Go 1.13 is module aware, so the output of 'go list' results in paths pointing to module cache (GOPATH/pkg/mod).
Non module aware go versions, the `Root` field in the `go list` output contains `GOPATH`. In module aware Go versions, it points to the root of module in module cache.
Earlier versions, the LICENSEs could be read by concatenating the `GOPATH` and `ImportPath` fields. Now the LICENSES need to be read by using `Root` and `Dir` fields which point to the root of the module and imported folder within the module.

This change fixes bill-of-materials test fails in etcd CI with Go 1.13.
etcd-io/etcd#11132
@vimalk78
Copy link
Contributor

@gyuho can you get the PR merged?

@vimalk78
Copy link
Contributor

@gyuho the PR is merged, we can close this issue.

@gyuho
Copy link
Contributor Author

gyuho commented Sep 14, 2019

@vimalk78 Thanks!

@gyuho
Copy link
Contributor Author

gyuho commented Sep 14, 2019

@vimalk78 Can we reenable bom tests?

vimalk78 added a commit to vimalk78/etcd that referenced this issue Sep 14, 2019
@vimalk78
travis: re-enable bom tests
e4cb346 
bill-of-materials was fixed for module aware 'go list' as part of coreos/license-bill-of-materials#17
So can re enable bom tests

fixes etcd-io#11132
@vimalk78 vimalk78 mentioned this issue Sep 14, 2019
Merged
@jingyih
Copy link
Contributor

jingyih commented Sep 18, 2019

bom test is still failing. Should we reopen this?

@vimalk78
Copy link
Contributor

yes we can reopen it.
The tests are failing because the CI is not pulling latest version of license-bill-of-materials

@gyuho
Copy link
Contributor Author

gyuho commented Sep 18, 2019

@jingyih @vimalk78 Sorry for delay. Rebuilding test image now.

@gyuho
Copy link
Contributor Author

gyuho commented Sep 18, 2019

Just pushed a new test image. Please try again.

@vimalk78
Copy link
Contributor

Bom test still seems to be failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

travis: re-enable bom tests vimalk78/etcd
3 participants
@vimalk78 @gyuho @jingyih