Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] TestOpenWithMaxIndex failure #14332

Closed
ahrtr opened this issue Aug 10, 2022 · 0 comments · Fixed by #14421
Closed

[test] TestOpenWithMaxIndex failure #14332

ahrtr opened this issue Aug 10, 2022 · 0 comments · Fixed by #14421
Labels
area/testing help wanted type/flake

Comments

@ahrtr
Copy link
Member

ahrtr commented Aug 10, 2022

Raised on the latest code on main branch.

--- FAIL: TestOpenWithMaxIndex (0.00s)
    testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestOpenWithMaxIndex2918559458/001: directory not empty

Refer to https://github.com/etcd-io/etcd/runs/7777195247?check_suite_focus=true
@ahrtr ahrtr changed the title TestOpenWithMaxIndex failure [test] TestOpenWithMaxIndex failure Aug 10, 2022
vsvastey added a commit to vsvastey/etcd that referenced this issue Sep 3, 2022
@vsvastey
testing: fix TestOpenWithMaxIndex cleanup
4bb26ae 
A WAL object was closed by defer, however the WAL was rewritten afterwards,
so defer closed already closed WAL but not the new one. It caused a data
race between writing file and cleaning up a temporary test directory,
which led to a non-deterministic bug.

Fixes etcd-io#14332

Signed-off-by: Vladimir Sokolov <[email protected]>
@vsvastey vsvastey mentioned this issue Sep 3, 2022
Merged
vsvastey added a commit to vsvastey/etcd that referenced this issue Sep 7, 2022
@vsvastey
testing: fix TestOpenWithMaxIndex cleanup
a4f140c 
A WAL object was closed by defer, however the WAL was rewritten afterwards,
so defer closed already closed WAL but not the new one. It caused a data
race between writing file and cleaning up a temporary test directory,
which led to a non-deterministic bug.

Fixes etcd-io#14332

Signed-off-by: Vladimir Sokolov <[email protected]>
vsvastey added a commit to vsvastey/etcd that referenced this issue Sep 8, 2022
@vsvastey
testing: fix TestOpenWithMaxIndex cleanup
1ed5dfc 
A WAL object was closed by defer, however the WAL was rewritten afterwards,
so defer closed already closed WAL but not the new one. It caused a data
race between writing file and cleaning up a temporary test directory,
which led to a non-deterministic bug.

Fixes etcd-io#14332

Signed-off-by: Vladimir Sokolov <[email protected]>
@vsvastey vsvastey mentioned this issue Sep 8, 2022
Merged
vsvastey added a commit to vsvastey/etcd that referenced this issue Sep 8, 2022
@vsvastey
testing: fix TestOpenWithMaxIndex cleanup
eef5e22 
A WAL object was closed by defer, however the WAL was rewritten afterwards,
so defer closed already closed WAL but not the new one. It caused a data
race between writing file and cleaning up a temporary test directory,
which led to a non-deterministic bug.

Fixes etcd-io#14332

Signed-off-by: Vladimir Sokolov <[email protected]>
@vsvastey vsvastey mentioned this issue Sep 8, 2022
Merged
kafuu-chino pushed a commit to kafuu-chino/etcd that referenced this issue Sep 9, 2022
@vsvastey @kafuu-chino
testing: fix TestOpenWithMaxIndex cleanup
618497d 
A WAL object was closed by defer, however the WAL was rewritten afterwards,
so defer closed already closed WAL but not the new one. It caused a data
race between writing file and cleaning up a temporary test directory,
which led to a non-deterministic bug.

Fixes etcd-io#14332

Signed-off-by: Vladimir Sokolov <[email protected]>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/etcd that referenced this issue Oct 7, 2022
@vsvastey
testing: fix TestOpenWithMaxIndex cleanup
2591d8a 
A WAL object was closed by defer, however the WAL was rewritten afterwards,
so defer closed already closed WAL but not the new one. It caused a data
race between writing file and cleaning up a temporary test directory,
which led to a non-deterministic bug.

Fixes etcd-io#14332

Signed-off-by: Vladimir Sokolov <[email protected]>
tjungblu pushed a commit to tjungblu/etcd that referenced this issue Jul 26, 2023
@vsvastey @tjungblu
testing: fix TestOpenWithMaxIndex cleanup
cbc83eb 
A WAL object was closed by defer, however the WAL was rewritten afterwards,
so defer closed already closed WAL but not the new one. It caused a data
race between writing file and cleaning up a temporary test directory,
which led to a non-deterministic bug.

Fixes etcd-io#14332

Signed-off-by: Vladimir Sokolov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing help wanted type/flake
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testing: fix TestOpenWithMaxIndex cleanup vsvastey/etcd
1 participant
@ahrtr