-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: test for etcdctl operations #4259
Comments
This was referenced Jan 27, 2016
gyuho
changed the title
add e2e test for etcdctl operations
e2e: test for etcdctl operations
Jan 30, 2016
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Jan 31, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes etcd-io#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Did some clean-ups.
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Jan 31, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes etcd-io#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Did some clean-ups.
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Jan 31, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes etcd-io#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Did some clean-ups.
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Jan 31, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes etcd-io#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Did some clean-ups.
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Jan 31, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes etcd-io#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Did some clean-ups. 5. Add // TODO: 'watch' sometimes times out in Semaphore CI environment but works fine in every other environments.
gyuho
added a commit
to gyuho/etcd
that referenced
this issue
Jan 31, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes etcd-io#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Did some clean-ups. 5. Add // TODO: 'watch' sometimes times out in Semaphore CI environment but works fine in every other environments. 6. increase test time
gyuho
referenced
this issue
in gyuho/etcd
Feb 1, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes coreos#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Add // TODO: 'watch' sometimes times out in Semaphore CI environment but works fine in every other environments. 5. increase test time
gyuho
referenced
this issue
in gyuho/etcd
Feb 1, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes coreos#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Add // TODO: 'watch' sometimes times out in Semaphore CI environment but works fine in every other environments. 5. increase test time
gyuho
referenced
this issue
in gyuho/etcd
Feb 1, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes coreos#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Add // TODO: 'watch' sometimes times out in Semaphore CI environment but works fine in every other environments. 5. increase test time
gyuho
referenced
this issue
in gyuho/etcd
Feb 1, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes coreos#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Add // TODO: 'watch' sometimes times out in Semaphore CI environment but works fine in every other environments. 5. increase test time
gyuho
referenced
this issue
in gyuho/etcd
Feb 1, 2016
1. proc.ExpectRegex returns the result of regexp.MatchReader, which does not return error even if there is no match of regex. This fixes it by checking the boolean value and if the boolean value is false, it returns error. 2. Adds more tests and finishes coreos#4259. 3. When we do the regex match correctly, curl request through SSL returns error. For the purpose of debugging, I changed it to log without failing the tests. etcdctl with SSL works fine. 4. Add // TODO: 'watch' sometimes times out in Semaphore CI environment but works fine in every other environments. 5. increase test time
Closing via #4361. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
etcdctl set
: e2e: add more etcdctl tests #4351etcdctl set
,watch
withno-sync
option: e2e: etcdctl test for proxy no-sync #4330etcdctl get
: e2e: add more etcdctl tests #4351etcdctl ls
: e2e: add more etcdctl tests #4351etcdctl mk
: e2e: check regexp.MatchReader return, curl SSL issue #4361etcdctl rm
: e2e: check regexp.MatchReader return, curl SSL issue #4361The text was updated successfully, but these errors were encountered: