Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: protecting membership change RPCs with auth #6899

Closed
mitake opened this issue Nov 25, 2016 · 0 comments
Closed

RFC: protecting membership change RPCs with auth #6899

mitake opened this issue Nov 25, 2016 · 0 comments
Assignees
@mitake

Comments

@mitake
Copy link
Contributor

mitake commented Nov 25, 2016

Currently membership change RPCs (e.g. MemberAdd()) isn't protected by the auth mechanism. As we discussed before, these RPCs should require root role. But The RPCs are a little bit different from other requests so it needs its own customized mechanism. I'd like to share my idea.

  1. In the functions e.g. EtcdServer.AddMember(), credentials of clients are checked. If the client doesn't have a root role, an error will be returned. If the client has the role, the revision number are set to raftpb.ConfChange. Let's call the new member raftpb.ConfChange.AuthRevision.

  2. The ConfChange requests are checked by RaftCluster.ValidateConfigurationChange() during its apply phase. In the function, the AuthRevision is compared with the latest state of AuthStore. If the revision is the latest, the check can be passed. If it is old, an error is returned and API functions (e.g. EtcdServer.AddMember()) will retry.

If the changes are reasonable and don't have problems, I'll send a PR.
mitake added a commit to mitake/etcd that referenced this issue Nov 28, 2016
@mitake
auth, etcdserver, raft: protect membership change operations with auth
b651fa9 
This commit protects membership change operations with auth. Only
users that have root role can issue the operations.

Implements etcd-io#6899
@mitake mitake mentioned this issue Nov 28, 2016
Merged
mitake added a commit to mitake/etcd that referenced this issue Dec 6, 2016
@mitake
auth, etcdserver: protect membership change operations with auth
5723e99 
This commit protects membership change operations with auth. Only
users that have root role can issue the operations.

Implements etcd-io#6899
mitake added a commit to mitake/etcd that referenced this issue Dec 6, 2016
@mitake
auth, etcdserver: protect membership change operations with auth
5a69781 
This commit protects membership change operations with auth. Only
users that have root role can issue the operations.

Implements etcd-io#6899
mitake added a commit to mitake/etcd that referenced this issue Dec 12, 2016
@mitake
auth, etcdserver: protect membership change operations with auth
e5aaa3b 
This commit protects membership change operations with auth. Only
users that have root role can issue the operations.

Implements etcd-io#6899
mitake added a commit to mitake/etcd that referenced this issue Dec 15, 2016
@mitake
auth, etcdserver: protect membership change operations with auth
86d7390 
This commit protects membership change operations with auth. Only
users that have root role can issue the operations.

Implements etcd-io#6899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitake mitake

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mitake