clientv3: clarify retry interceptor logging #10476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
reviewed
Feb 15, 2019
clientv3/retry_interceptor.go
Outdated
| if lastErr == nil { | ||
| return nil | ||
| } | ||
| logger.Warn( | ||
| "retrying unary intercept failed", |
There was a problem hiding this comment.
I understand this function is an interceptor, but the actual function call we are retrying is the invoker. So this message (and other similar messages in this function) sounds a little wired to me. It sounds like some interception failed, which is not what actually happened. Maybe something like "retrying of unary invoker failed" or simply "retrying failed"?
There was a problem hiding this comment.
Good point. Updated. PTAL.
Log only when it errors + some clarification Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log only when it errors + some clarification.
FYI. I am debugging around #9949.
And resolve kubernetes/kubernetes#72102.