*: enable lease checkpoint via experimental flag #10797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primary lessor persist lease remainingTTL only if experimental flag "--experimental-enable-lease-checkpoint" is set.
jingyih
force-pushed
the
lease_checkpoint_enabled_by_experimental_flag
branch
from
9be8443 to
e67b982
Compare
|
+1 to making the etcd 3.4 safer from a RAFT compatibility perspective. LGTM |
gyuho
approved these changes
Jun 5, 2019
Thanks. Added 5af3723. |
|
lgtm |
@jingyih My etcd server is running with env flags, so flag "--experimental-enable-lease-checkpoint" is equal to env flag "ETCD_EXPERIMENTAL_ENABLE_LEASE_CHECKPOINT=true"? Looking forward to your reply. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with @jpbetz. In etcd 3.4, let's put lease checkpoint feature #9924 behind an experimental flag. The primary concern is that the feature introduced a new raft entry type
LeaseCheckpointRequest. This will make the design of HA cluster downgrade difficult, as servers of old version panics on unknown raft type (during apply).With this PR, lease checkpoint feature is enabled only if "--experimental-enable-lease-checkpoint" is set.
cc @jpbetz @xiang90 @gyuho