Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Rewrite etcd requests to use operations #15059

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

serathius
Copy link
Member

@serathius serathius force-pushed the linearizability-operations branch from da49cbe to 94b5068 Compare January 1, 2023 18:30
Signed-off-by: Marek Siarkowicz <[email protected]>
@serathius serathius force-pushed the linearizability-operations branch from 94b5068 to 3b623af Compare January 1, 2023 18:54
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2023

Codecov Report

Merging #15059 (e73f55d) into main (e73f55d) will not change coverage.
The diff coverage is n/a.

❗ Current head e73f55d differs from pull request most recent head 3b623af. Consider uploading reports for the commit 3b623af to get more accurate results

@@           Coverage Diff           @@
##             main   #15059   +/-   ##
=======================================
  Coverage   74.85%   74.85%           
=======================================
  Files         415      415           
  Lines       34287    34287           
=======================================
  Hits        25666    25666           
  Misses       6997     6997           
  Partials     1624     1624           
Flag Coverage Δ
all 74.85% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tests/linearizability/model_test.go Show resolved Hide resolved
tests/linearizability/model.go Outdated Show resolved Hide resolved
tests/linearizability/model.go Outdated Show resolved Hide resolved
tests/linearizability/model.go Show resolved Hide resolved
tests/linearizability/model.go Outdated Show resolved Hide resolved
tests/linearizability/model.go Show resolved Hide resolved
tests/linearizability/model.go Show resolved Hide resolved
tests/linearizability/model.go Outdated Show resolved Hide resolved
tests/linearizability/model.go Show resolved Hide resolved
tests/linearizability/model.go Show resolved Hide resolved
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me with a couple of minor comments, which can be resolved in separate PRs.

@serathius serathius force-pushed the linearizability-operations branch from b87efe0 to 6877122 Compare January 9, 2023 13:42
@serathius serathius merged commit a992fb5 into etcd-io:main Jan 9, 2023
@serathius serathius deleted the linearizability-operations branch June 15, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants