-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Rewrite etcd requests to use operations #15059
Conversation
da49cbe
to
94b5068
Compare
Signed-off-by: Marek Siarkowicz <[email protected]>
94b5068
to
3b623af
Compare
Codecov Report
@@ Coverage Diff @@
## main #15059 +/- ##
=======================================
Coverage 74.85% 74.85%
=======================================
Files 415 415
Lines 34287 34287
=======================================
Hits 25666 25666
Misses 6997 6997
Partials 1624 1624
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me with a couple of minor comments, which can be resolved in separate PRs.
Signed-off-by: Marek Siarkowicz <[email protected]>
b87efe0
to
6877122
Compare
cc @ahrtr @ptabor