-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog: add 3.4 and 3.5 note about go 1.20.13 #17309
changelog: add 3.4 and 3.5 note about go 1.20.13 #17309
Conversation
Hi @ivanvc. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for completing the upgrade @ivanvc - just a small tweak needed for 3.5 changelog then this will be good to merge.
CHANGELOG/CHANGELOG-3.5.md
Outdated
@@ -16,7 +16,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
- Fix [url redirects while checking peer urls during new member addition](https://github.com/etcd-io/etcd/pull/16986) | |||
|
|||
### Dependencies | |||
- Compile binaries using [go 1.20.12](https://github.com/etcd-io/etcd/pull/17077) | |||
- Compile binaries using [go 1.20.13](https://github.com/etcd-io/etcd/pull/17275) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.5.11
has already been released so we need to leave this line as is and make a new entry for ### Dependencies
under 3.5.12
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we need separate lines each dependency update, at least historically we only kept the latest update of one kind.
Signed-off-by: Ivan Valdes <[email protected]>
606191a
to
c83feeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks
Updates 3.4 and 3.5 CHANGELOGs to add a line that the binaries are compiled with go version 1.20.13.
Related to #17269
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.