Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Add approvals gh workflows. #17619

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Mar 20, 2024

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Releated: #17616 (review)

Actually, this config is not work for release3.5 and release3.4, we need let this workflow file exist at release-3.5.

branches:
- main
- release-3.5
- release-3.4

Once this PR is merged, we can verify on #17616

@k8s-ci-robot
Copy link

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liangyuanpeng liangyuanpeng changed the title Add approvals gh workflows. [3.5] Add approvals gh workflows. Mar 20, 2024
@liangyuanpeng
Copy link
Contributor Author

/cc @jmhbnz

@k8s-ci-robot k8s-ci-robot requested a review from jmhbnz March 20, 2024 09:02
@liangyuanpeng
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link

@liangyuanpeng: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmhbnz
Copy link
Member

jmhbnz commented Mar 20, 2024

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @liangyuanpeng

@liangyuanpeng liangyuanpeng force-pushed the approve_ghaction_3.5 branch from 75fe45c to b6df59c Compare April 6, 2024 14:40
@serathius serathius merged commit 4ffa5c5 into etcd-io:release-3.5 Apr 7, 2024
23 checks passed
@liangyuanpeng liangyuanpeng deleted the approve_ghaction_3.5 branch April 7, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants