-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Add approvals gh workflows. #17619
[3.5] Add approvals gh workflows. #17619
Conversation
Hi @liangyuanpeng. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @jmhbnz |
/retest |
@liangyuanpeng: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @liangyuanpeng
Signed-off-by: Lan Liang <[email protected]>
75fe45c
to
b6df59c
Compare
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Releated: #17616 (review)
Actually, this config is not work for
release3.5
andrelease3.4
, we need let this workflow file exist atrelease-3.5
.etcd/.github/workflows/gh-workflow-approve.yaml
Lines 9 to 12 in 6f55dfa
Once this PR is merged, we can verify on #17616