Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: add support AllowedCN and AllowedHostname #18068

Merged
merged 1 commit into from
May 25, 2024
Merged

CHANGELOG: add support AllowedCN and AllowedHostname #18068

merged 1 commit into from
May 25, 2024

Conversation

ArkaSaha30
Copy link
Contributor

This PR will update the CHANGELOG-3.5.md with the inclusion of backport PR #18063 for v3.5.14 release

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @ArkaSaha30. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ArkaSaha30
Copy link
Contributor Author

cc @ivanvc @ahrtr

jmhbnz
jmhbnz approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just one optional formatting nit below. Thanks @ArkaSaha30

CHANGELOG/CHANGELOG-3.5.md Outdated Show resolved Hide resolved
@jmhbnz
Copy link
Member

jmhbnz commented May 25, 2024

/ok-to-test

@ahrtr ahrtr merged commit bb701b9 into etcd-io:main May 25, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
ok-to-test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArkaSaha30 @k8s-ci-robot @jmhbnz @ahrtr