Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping #19166

Open
wants to merge 3 commits into
base: release-3.4
Choose a base branch
from

Conversation

joshuazh-x
Copy link
Contributor

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshuazh-x
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @joshuazh-x. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joshuazh-x joshuazh-x changed the title Fix embed close deadlock 3.4 Backport https://github.com/etcd-io/etcd/pull/19139 to 3.4 Jan 10, 2025
@ivanvc
Copy link
Member

ivanvc commented Jan 10, 2025

/retitle [3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping
/ok-to-test

@k8s-ci-robot k8s-ci-robot changed the title Backport https://github.com/etcd-io/etcd/pull/19139 to 3.4 [3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping Jan 10, 2025
@@ -29,8 +29,10 @@ import (
"testing"
"time"

"github.com/stretchr/testify/require"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/require"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants