Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate flag experimental-watch-progress-notify-interval to use watch-progress-notify-interval #19248

Merged
merged 2 commits into from
Jan 23, 2025
Merged

migrate flag experimental-watch-progress-notify-interval to use watch-progress-notify-interval #19248

merged 2 commits into from
Jan 23, 2025

Conversation

gangli113
Copy link
Contributor

Fixes one flag described in: #19141

The experimental flags are marked as deprecated and will be decommissioned in v3.7.

@k8s-ci-robot
Copy link

Hi @gangli113. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (32cfd45) to head (c661931).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 79.53% <100.00%> (+0.03%) ⬆️
server/embed/etcd.go 76.49% <100.00%> (ø)
server/etcdmain/config.go 72.15% <100.00%> (+0.35%) ⬆️

... and 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19248      +/-   ##
==========================================
- Coverage   68.83%   68.82%   -0.02%     
==========================================
  Files         420      420              
  Lines       35678    35681       +3     
==========================================
- Hits        24560    24557       -3     
- Misses       9688     9693       +5     
- Partials     1430     1431       +1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32cfd45...c661931. Read the comment docs.

@gangli113
Copy link
Contributor Author

/cc @siyuanfoundation @serathius @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Jan 21, 2025

/ok-to-test

siyuanfoundation
siyuanfoundation reviewed Jan 21, 2025
View reviewed changes
tests/robustness/main_test.go Outdated Show resolved Hide resolved
tests/framework/e2e/cluster.go Show resolved Hide resolved
@siyuanfoundation siyuanfoundation mentioned this pull request Jan 15, 2025
Open
11 tasks
@gangli113
Copy link
Contributor Author

/retest-required

ahrtr
ahrtr reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of minor comments.

Please also squash the commits.

server/etcdmain/config_test.go Outdated Show resolved Hide resolved
server/etcdmain/config_test.go Outdated Show resolved Hide resolved
server/etcdmain/config_test.go Outdated Show resolved Hide resolved
@gangli113 gangli113 force-pushed the experimentalFlag branch 2 times, most recently from ac5c19e to c893658 Compare January 23, 2025 18:56
@gangli113
Squashed commit of the following:
1ef99e7 
commit 4fc53fa2536b4ca911c0d2c24a475e22c9df4564
Author: Gang Li <[email protected]>
Date:   Thu Jan 23 10:32:01 2025 -0800

    use require.NoError in error check

    Signed-off-by: Gang Li <[email protected]>

commit d3c595a
Author: Gang Li <[email protected]>
Date:   Wed Jan 22 14:41:50 2025 -0800

    fix name typo

    Signed-off-by: Gang Li <[email protected]>

commit 4a848cd
Author: Gang Li <[email protected]>
Date:   Tue Jan 21 14:35:50 2025 -0800

    use experimental flag in robustness scenario

    Signed-off-by: Gang Li <[email protected]>

commit 346020b
Author: Gang Li <[email protected]>
Date:   Tue Jan 21 10:50:58 2025 -0800

    add TODO

    Signed-off-by: Gang Li <[email protected]>

commit edf6845
Author: Gang Li <[email protected]>
Date:   Tue Jan 21 10:44:54 2025 -0800

    migrate to use watch-progress-notify-interval flag

    Signed-off-by: Gang Li <[email protected]>

Signed-off-by: Gang Li <[email protected]>
@gangli113 gangli113 requested a review from ahrtr January 23, 2025 19:24
ahrtr
ahrtr approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, gangli113, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit b16b8dc into etcd-io:main Jan 23, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@siyuanfoundation siyuanfoundation siyuanfoundation approved these changes

@serathius serathius Awaiting requested review from serathius

Assignees
No one assigned
Labels
approved area/robustness-testing area/testing ok-to-test size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gangli113 @k8s-ci-robot @ahrtr @siyuanfoundation