Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align NewConfig with AddFlags defaults #19254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Align NewConfig with AddFlags defaults

5a556d8
Select commit
Loading
Failed to load commit list.
Open

Align NewConfig with AddFlags defaults #19254

Align NewConfig with AddFlags defaults
5a556d8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2025 in 0s

68.80% (+0.01%) compared to 8c1547b

View this Pull Request on Codecov

68.80% (+0.01%) compared to 8c1547b

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (8c1547b) to head (5a556d8).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 79.47% <100.00%> (-0.03%) ⬇️

... and 29 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19254      +/-   ##
==========================================
+ Coverage   68.79%   68.80%   +0.01%     
==========================================
  Files         420      420              
  Lines       35649    35669      +20     
==========================================
+ Hits        24524    24542      +18     
+ Misses       9698     9697       -1     
- Partials     1427     1430       +3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1547b...5a556d8. Read the comment docs.