storage: add store.LastTxnEvents to improve watch #3817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the wrong range statistics when using watch. This avoids heavy Range call to watch events, and kills related TODO. This makes the code cleaner.
|
I will take this over and use the same approach to batch events sending to watchings. |
|
Closing this in favor of #4091. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the wrong range statistics when using watch.
This avoids heavy Range call to watch events, and kills related TODO.
This makes the code cleaner.
This keeps the original logic that only returns last event on one key in one txn, but it doesn't need heavy ongoingTxn anymore. I may improve the behavior of returned events in follow-ups.
LatestTxnEventsreturns events struct today, and it may return raw kv data in the future to save the cost of marshaling and unmarshaling.