clientv3: add quote that Go v1.9 is required #8583
Conversation
clientv3/README.md
Outdated
| @@ -10,6 +10,8 @@ | |||
| go get github.com/coreos/etcd/clientv3 | |||
| ``` | |||
|
|
|||
| > Requires Go v1.9 | |||
There was a problem hiding this comment.
probably make this bold instead?
clientv3/README.md
Outdated
| @@ -10,7 +10,7 @@ | |||
| go get github.com/coreos/etcd/clientv3 | |||
| ``` | |||
|
|
|||
| > Requires Go v1.9 | |||
| > **Requires Go v1.9+** | |||
There was a problem hiding this comment.
it makes this less significant.
There was a problem hiding this comment.
A quote is the closest thing to a "notice" in markdown. I think it draws more attention since it's a diff. color. But if you want it without no probs.
There was a problem hiding this comment.
do we need go 1.9 to build both etcd and etcd client? if that's the case, should we doc requirement on the front page?
There was a problem hiding this comment.
Then maybe just update https://github.com/coreos/etcd#getting-etcd?
For those wanting to try the very latest version,
To
For those wanting to try the very latest version/client,
?
There was a problem hiding this comment.
the doc https://github.com/coreos/etcd/blob/master/Documentation/dl_build.md#build-the-latest-version has outdated go version requirement.
There was a problem hiding this comment.
@fanminshi Yeah that needs to be fixed as well, in a separate patch.
There was a problem hiding this comment.
clientv3 is usually used as a standalone library. it worth adding a link here to the go version requirement if we want to avoid duplication.
|
Won't fix |
|
I try etcd v3.2.9 today with golang 1.9 and still getting the error
|
Updated clientv3 with quote that Go v1.9 is required
#8548