clientv3: remove redundant retries in Lease, set FailFast=true #8718
Conversation
Signed-off-by: Gyu-Ho Lee <[email protected]>
clientv3/retry.go
Outdated
| @@ -168,7 +168,7 @@ type retryLeaseClient struct { | |||
| readRetry retryRPCFunc | |||
| } | |||
|
|
|||
| // RetryLeaseClient implements a LeaseClient that uses the client's FailFast retry policy. | |||
| // RetryLeaseClient implements a LeaseClient. | |||
There was a problem hiding this comment.
then why do we need the leaseClient at line167?
There was a problem hiding this comment.
can we rename the readRetry to repeatableRetry? leaseGrant is not really read.
we will have a retrypolicy: repeatable defined in the future.
There was a problem hiding this comment.
It has to call rlc.LeaseClient where LeaseClient is pb.LeaseClient?
There was a problem hiding this comment.
i mean why it is embedded. it is that way so users can call to it directly. but now everything should call through the func we define on retryleaseclient.
There was a problem hiding this comment.
can we hide the raw client by not embedding it?
There was a problem hiding this comment.
Right, since retryleaseclient implements the interface, no need to embed. Changed it unexported.
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
|
lgtm |
Separate out from #8710.
c.f. #8691.