Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: document auto-compaction logic #9468

Merged
merged 2 commits into from
Mar 21, 2018
Merged

*: document auto-compaction logic #9468

merged 2 commits into from
Mar 21, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Mar 20, 2018

Related to #9443.

This summarizes how our auto-compaction logic has been changed.

/cc @fanminshi @yudai

@gyuho
Copy link
Contributor Author

gyuho commented Mar 20, 2018

Current auto-compaction logic makes sense to me, but it gets too aggressive when the compaction period is less than 1-hour (as discussed in #9443). We could add additional minimum value checks.

@yudai
Copy link
Contributor

yudai commented Mar 20, 2018

For 3.2, I think the description is correct :)

@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6153e9f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9468   +/-   ##
=========================================
  Coverage          ?   72.56%           
=========================================
  Files             ?      364           
  Lines             ?    30890           
  Branches          ?        0           
=========================================
  Hits              ?    22414           
  Misses            ?     6847           
  Partials          ?     1629

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6153e9f...e9e90bd. Read the comment docs.

@gyuho gyuho merged commit da1d3e6 into etcd-io:master Mar 21, 2018
@gyuho gyuho deleted the compactor-doc branch March 21, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants