Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3/integration: log test failures from slow balancer as TODO #9555

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Apr 10, 2018

Balancer tests have been flaky since last balancer rewrite.
Should be from slow balancer failover. Once we re-rewrite balancer
with roundrobin, there should be no more flaky tests as below:

TestBalancerUnderServerStopInflightLinearizableGetOnRestart (27.62s)
server_shutdown_test.go:343: context deadline exceeded

TestBalancerUnderServerShutdownDelete (3.22s)
util.go:32: context deadline exceeded

/cc @jpbetz

Balancer tests have been flaky since last balancer rewrite.
Should be from slow balancer failover. Once we re-rewrite balancer
with roundrobin, there should be no more flaky tests as below:

TestBalancerUnderServerStopInflightLinearizableGetOnRestart (27.62s)
server_shutdown_test.go:343: context deadline exceeded

TestBalancerUnderServerShutdownDelete (3.22s)
util.go:32: context deadline exceeded

Signed-off-by: Gyuho Lee <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #9555 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9555      +/-   ##
==========================================
- Coverage    72.5%   72.36%   -0.14%     
==========================================
  Files         368      368              
  Lines       31339    31339              
==========================================
- Hits        22721    22678      -43     
- Misses       6982     7029      +47     
+ Partials     1636     1632       -4
Impacted Files Coverage Δ
clientv3/integration/util.go 66.66% <100%> (ø) ⬆️
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
client/client.go 70.26% <0%> (-14.38%) ⬇️
pkg/adt/interval_tree.go 83.48% <0%> (-6.91%) ⬇️
mvcc/watcher.go 96.29% <0%> (-3.71%) ⬇️
clientv3/balancer/grpc1.7-health.go 85.17% <0%> (-1.75%) ⬇️
proxy/grpcproxy/lease.go 79.18% <0%> (-1.36%) ⬇️
proxy/grpcproxy/watch.go 86.33% <0%> (-1.25%) ⬇️
pkg/proxy/server.go 58.81% <0%> (ø) ⬆️
etcdserver/server.go 79.8% <0%> (+0.22%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e095ee4...3a7b5c1. Read the comment docs.

@gyuho gyuho merged commit 170c8bb into etcd-io:master Apr 10, 2018
@gyuho gyuho deleted the aaa branch April 10, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants