Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: not print password in the warning message of expensive re… #9636

Closed
wants to merge 1 commit into from
Closed

etcdserver: not print password in the warning message of expensive re… #9636

wants to merge 1 commit into from

Conversation

mitake
Copy link
Contributor

@mitake mitake commented Apr 26, 2018

…quest

Fix #9635

Could you try it, @YeruchamB ?

@gyuho
Copy link
Contributor

gyuho commented Apr 26, 2018

lgtm /cc @xiang90

@YeruchamB
Copy link

@mitake My setup downloads from one of releases and doesnt build the binary itself... it would take a while to change.

@gyuho
Copy link
Contributor

gyuho commented Apr 27, 2018 •
edited
Loading

@mitake Can still see passwords from user add command. Redact all AuthUser* requests?

@gyuho gyuho mentioned this pull request Apr 30, 2018
Merged
@gyuho
Copy link
Contributor

gyuho commented Apr 30, 2018

Cherry-picked in #9661.

@gyuho gyuho closed this Apr 30, 2018
@YeruchamB YeruchamB mentioned this pull request May 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/auth area/security
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitake @gyuho @YeruchamB