Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm maintainership for etcd website #691

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Jun 4, 2023

Currently it is not fully clear who is an etcd website maintainer because:

This can create friction for pull requests because contributors don't know who they need to ping if they have questions or want help.

As a starting point I propose we include a MAINTAINERS file specifying all members of etcd-io/maintainers-etcd as website maintainers.

Relates to #679

@jmhbnz
Copy link
Member Author

jmhbnz commented Jun 4, 2023

Raised #692 to sort out why deploy previews are failing recently.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not instead populate the existing team maintainers-website -- or better yet, use the name website-maintainers. That would create a semantically meaningful and useful ID that we could use in CODEOWNERS files, or assign issues to, cc all maintainers, etc.

FYI, issue #692 has been fixed.

/cc @nate-double-u

@jmhbnz
Copy link
Member Author

jmhbnz commented Jun 5, 2023

Why not instead populate the existing team maintainers-website -- or better yet, use the name website-maintainers. That would create a semantically meaningful and useful ID that we could use in CODEOWNERS files, or assign issues to, cc all maintainers, etc.

Hey @chalin, thanks for fixing the netlify previews!

Refer linked issue #679 where I am proposing that the github team be populated. In relation to the actual issue of unclear maintainership I am not particularly worried which approach gets taken, file based or github team based, provided one is completed to remove the ambiguity. I raised this pr to try and spur some conversation and hopefully get one or both implemented.

Note there has been a recent trend to rollout MAINTAINERS to all etcd-io subprojects starting recently with raft and bbolt.

@jmhbnz jmhbnz requested review from serathius and ahrtr June 8, 2023 08:14
@ahrtr
Copy link
Member

ahrtr commented Jun 8, 2023

Thanks @jmhbnz for raising the PR. Two comments:

  1. Not sure why the workflow checks are failed. Could you resolve the failures?
  2. I see the the following three contributors are also has admin or maintain role of this repo. But I am a little surprised that they are not even a member of etcd org.
    • @nate-double-u (document writer for etcd. @serathius mentioned this before)
    • @chalin (already an admin of this repo, I did not know it before.)
    • @jberkus (already has role Maintain of this repo, I did not know it before. But I see @jberkus has been contributing to etcd's doc, thx)

@jmhbnz jmhbnz force-pushed the clarify-repository-maintainers branch from 3ebf569 to e97265a Compare June 8, 2023 08:43
@jmhbnz
Copy link
Member Author

jmhbnz commented Jun 8, 2023

  1. Not sure why the workflow checks are failed. Could you resolve the failures?

Just needed to merge in the fix to the workflows which was completed under #692.

  1. I see the the following three contributors are also has admin or maintain role of this repo. But I am a little surprised that they are not even a member of etcd org.

Please let me know if you would like to add any names to the list, keen to clear up any ambiguity :)

@ahrtr
Copy link
Member

ahrtr commented Jun 8, 2023

Please let me know if you would like to add any names to the list, keen to clear up any ambiguity :)

Suggest to add all of them into the maintainer list. I am just curious why don't we follow the already established membership guide.

@spzala
Copy link
Member

spzala commented Jun 8, 2023

Thanks @jmhbnz for raising the PR. Two comments:

1. Not sure why the workflow checks are failed. Could you resolve the failures?

2. I see the the following three contributors are also has admin or maintain role of this repo. But I am a little surprised that they are not even a member of etcd org.
   
   * @nate-double-u (document writer for etcd. @serathius mentioned this before)
   * @chalin (already an admin of this repo, I did not know it before.)
   * @jberkus (already has role Maintain of this repo, I did not know it before. But I see @jberkus has been contributing to etcd's doc, thx)

@ahrtr agree, it's not clear. @nate-double-u and @chalin are helping from CNCF side and they led the website redesign work after etcd project graduation in the past. Now that we are going to have a maintainers file specifically for this repo, we should add them and Josh (after talking to them) in this PR or in a separate one. Thanks! @jmhbnz thanks for working on this PR!

@jmhbnz jmhbnz force-pushed the clarify-repository-maintainers branch from 4200691 to 7878905 Compare June 9, 2023 17:21
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use my CNCF email address if possible. Thx

MAINTAINERS Outdated Show resolved Hide resolved
@jmhbnz
Copy link
Member Author

jmhbnz commented Jun 9, 2023

@ahrtr agree, it's not clear. @nate-double-u and @chalin are helping from CNCF side and they led the website redesign work after etcd project graduation in the past. Now that we are going to have a maintainers file specifically for this repo, we should add them and Josh (after talking to them) in this PR or in a separate one. Thanks! @jmhbnz thanks for working on this PR!

@jberkus, @nate-double-u, @chalin - Before we proceed further with this pr can you please respond below if you are in agreement to be formally added as a maintainer for etcd-io/website, acknowledging the requirements and responsibilities this entails?

@jmhbnz jmhbnz force-pushed the clarify-repository-maintainers branch from 7878905 to 251bda8 Compare June 9, 2023 17:34
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmhbnz A small things on convention, please add new members in an alphabetical order. Thanks!

@jmhbnz jmhbnz force-pushed the clarify-repository-maintainers branch from 251bda8 to 50a14b4 Compare June 9, 2023 17:53
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jmhbnz

Once this PR gets merged, we can add all maintainers into github team website-maintainers?

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmhbnz thanks for addressing my comment quickly!

@jberkus
Copy link
Contributor

jberkus commented Jun 12, 2023

Yes. That said, I'm good at editing content but fairly poor at troubleshooting netlify stuff, so I hope that we have access to @chalin for some time to come.

@nate-double-u
Copy link
Contributor

@ahrtr agree, it's not clear. @nate-double-u and @chalin are helping from CNCF side and they led the website redesign work after etcd project graduation in the past. Now that we are going to have a maintainers file specifically for this repo, we should add them and Josh (after talking to them) in this PR or in a separate one. Thanks! @jmhbnz thanks for working on this PR!

@jberkus, @nate-double-u, @chalin - Before we proceed further with this pr can you please respond below if you are in agreement to be formally added as a maintainer for etcd-io/website, acknowledging the requirements and responsibilities this entails?

@jmhbnz I'm happy to be a maintainer on the etcd website. I haven't gone through and joined all the email lists and slack channels, but I expect this is part of the process.

Yes. That said, I'm good at editing content but fairly poor at troubleshooting netlify stuff, so I hope that we have access to @chalin for some time to come.

I'm also happy to manage Netlify issues as they come up if @chalin (or other folks) aren't available to troubleshoot.

MAINTAINERS Outdated Show resolved Hide resolved
@jmhbnz jmhbnz force-pushed the clarify-repository-maintainers branch from 50a14b4 to c818146 Compare June 13, 2023 00:51
@chalin
Copy link
Contributor

chalin commented Jun 13, 2023

@chalin - Before we proceed further with this pr can you please respond below if you are in agreement to be formally added as a maintainer for etcd-io/website, acknowledging the requirements and responsibilities this entails?

@jmhbnz - yes, I agree to be added as a maintainer for the website portion of the etcd project, in the mainly role of web dev and technical writer, including support for Google Analytics (4) and Netlify. My tech writer role would be mainly for Information Architecture (site org) recommendations, and some limited contributions content (again, mostly reorg, copyediting). Like Nate, I have not registered to the various lists. Note that I'll be more involved in etcd.io website work as my responsibilities of other projects diminish -- it's looking like that will happen in Q3. Thanks!

@ahrtr
Copy link
Member

ahrtr commented Jul 21, 2023

cc @mitake @ptabor @serathius @wenjiaswe

MAINTAINERS Outdated Show resolved Hide resolved
@jmhbnz jmhbnz force-pushed the clarify-repository-maintainers branch from c818146 to 489786c Compare July 21, 2023 22:00
@jmhbnz
Copy link
Member Author

jmhbnz commented Jul 21, 2023

Note following etcd-io/etcd#16234 I have also added myself as reviewer here.

@ahrtr
Copy link
Member

ahrtr commented Jul 28, 2023

ping @wenjiaswe and @serathius

MAINTAINERS Outdated Show resolved Hide resolved
@jmhbnz jmhbnz force-pushed the clarify-repository-maintainers branch from 489786c to 372857c Compare July 29, 2023 20:41
@ahrtr
Copy link
Member

ahrtr commented Jul 31, 2023

With the approval of 5 maintainers and 1 reviewer, merging this PR...

Afterwards, I will add all maintainers into maintainers-website.

@ahrtr ahrtr merged commit e574b78 into etcd-io:main Jul 31, 2023
@spzala
Copy link
Member

spzala commented Jul 31, 2023

Sounds good. Thanks @ahrtr !!

@ahrtr
Copy link
Member

ahrtr commented Aug 2, 2023

@jberkus @nate-double-u @chalin I have already invited you to join the etcd-io org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants