-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm maintainership for etcd website #691
Conversation
Raised #692 to sort out why deploy previews are failing recently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not instead populate the existing team maintainers-website -- or better yet, use the name website-maintainers
. That would create a semantically meaningful and useful ID that we could use in CODEOWNERS files, or assign issues to, cc all maintainers, etc.
FYI, issue #692 has been fixed.
/cc @nate-double-u
Hey @chalin, thanks for fixing the netlify previews! Refer linked issue #679 where I am proposing that the github team be populated. In relation to the actual issue of unclear maintainership I am not particularly worried which approach gets taken, file based or github team based, provided one is completed to remove the ambiguity. I raised this pr to try and spur some conversation and hopefully get one or both implemented. Note there has been a recent trend to rollout |
Thanks @jmhbnz for raising the PR. Two comments:
|
3ebf569
to
e97265a
Compare
Just needed to merge in the fix to the workflows which was completed under #692.
Please let me know if you would like to add any names to the list, keen to clear up any ambiguity :) |
Suggest to add all of them into the maintainer list. I am just curious why don't we follow the already established membership guide. |
@ahrtr agree, it's not clear. @nate-double-u and @chalin are helping from CNCF side and they led the website redesign work after etcd project graduation in the past. Now that we are going to have a maintainers file specifically for this repo, we should add them and Josh (after talking to them) in this PR or in a separate one. Thanks! @jmhbnz thanks for working on this PR! |
4200691
to
7878905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use my CNCF email address if possible. Thx
@jberkus, @nate-double-u, @chalin - Before we proceed further with this pr can you please respond below if you are in agreement to be formally added as a maintainer for |
7878905
to
251bda8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jmhbnz A small things on convention, please add new members in an alphabetical order. Thanks!
251bda8
to
50a14b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @jmhbnz
Once this PR gets merged, we can add all maintainers into github team website-maintainers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmhbnz thanks for addressing my comment quickly!
Yes. That said, I'm good at editing content but fairly poor at troubleshooting netlify stuff, so I hope that we have access to @chalin for some time to come. |
@jmhbnz I'm happy to be a maintainer on the etcd website. I haven't gone through and joined all the email lists and slack channels, but I expect this is part of the process.
I'm also happy to manage Netlify issues as they come up if @chalin (or other folks) aren't available to troubleshoot. |
50a14b4
to
c818146
Compare
@jmhbnz - yes, I agree to be added as a maintainer for the website portion of the etcd project, in the mainly role of web dev and technical writer, including support for Google Analytics (4) and Netlify. My tech writer role would be mainly for Information Architecture (site org) recommendations, and some limited contributions content (again, mostly reorg, copyediting). Like Nate, I have not registered to the various lists. Note that I'll be more involved in etcd.io website work as my responsibilities of other projects diminish -- it's looking like that will happen in Q3. Thanks! |
c818146
to
489786c
Compare
Note following etcd-io/etcd#16234 I have also added myself as reviewer here. |
ping @wenjiaswe and @serathius |
Signed-off-by: James Blair <[email protected]>
489786c
to
372857c
Compare
With the approval of 5 maintainers and 1 reviewer, merging this PR... Afterwards, I will add all maintainers into maintainers-website. |
Sounds good. Thanks @ahrtr !! |
@jberkus @nate-double-u @chalin I have already invited you to join the etcd-io org. |
Currently it is not fully clear who is an etcd website maintainer because:
MAINTAINERS
file included at the root level of this repo.This can create friction for pull requests because contributors don't know who they need to ping if they have questions or want help.
As a starting point I propose we include a
MAINTAINERS
file specifying all members ofetcd-io/maintainers-etcd
as website maintainers.Relates to #679