Merge pull request #87 from heyitsanthony/fix-get-root

zketcd: don't crash on getting root directory

integration/integration_test.go

@@ -28,6 +28,14 @@ var (
 	acl = zk.WorldACL(zk.PermAll)
 )
 
+func TestGetRoot(t *testing.T) {
+	runTest(t, func(t *testing.T, c *zk.Conn) {
+		if _, _, err := c.Get("/"); err != nil {
+			t.Fatal(err)
+		}
+	})
+}
+
 func TestDirStat(t *testing.T) {
 	runTest(t, func(t *testing.T, c *zk.Conn) {
 		if _, err := c.Create("/abc", []byte(""), 0, acl); err != nil {

zketcd.go

@@ -324,7 +324,11 @@ func (z *zkEtcd) GetData(xid Xid, op *GetDataRequest) ZKResponse {
 		}
 		z.s.Watch(zxid, xid, p, EventNodeDataChanged, f)
 	}
-	datResp.Data = []byte(txnresp.Responses[2].GetResponseRange().Kvs[0].Value)
+
+	// Root directory has no data.
+	if p != rootPath {
+		datResp.Data = []byte(txnresp.Responses[2].GetResponseRange().Kvs[0].Value)
+	}
 
 	glog.V(7).Infof("GetData(%v) = (zxid=%v, resp=%+v)", xid, zxid, *datResp)
 	return mkZKResp(xid, zxid, datResp)