This repository has been archived by the owner on Oct 7, 2023. It is now read-only.
preserve ephemeral owner and permit directory deletion after losing ephemeral children #89
+55
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check ephemeral owner is retained after updating node data * check a directory emptied by ephemeral node loss can be deleted
Ephemeral node deletion doesn't update the CVersion, so the directory will seem to have children when it doesn't after losing ephemeral nodes. Note: this fails cross-checking and etcd likely needs an API extension to get full zk compatibility. Fixes etcd-io#88
gyuho
approved these changes
Apr 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @tsuraan
This is a partial fix. etcd will probably need an API extension to accurately cross-check against zookeeper.
Fixes #88