Fix/clique eip2 config #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used by misconfigured EIP2 EthashEIP2F interface method is poorly named. EIP2 is NOT Ethash-specific. It is a messy EIP, and specifies a lot of different things. Among them, it specifies gas cost of contract creation, changing the original cost of 21000 to 53000. The issue cited below sees a variance of 32000 in gas cost outcomes for a contract creation. This is explained by the difference in the intrinsic gas cost without and with this EIP. Fixes #120 Signed-off-by: meows <[email protected]>
... and out of the Ethash module. This causes YoloV1 tests to pass. Signed-off-by: meows <[email protected]>
…ethv0,parity: rename EthashEIP2Transition -> EIP2Transition Signed-off-by: meows <[email protected]>
This should prove that Clique configurations are interchangeable at the consensus state level with their Ethash counterpart. Currently only installed for the Istanbul config since that includes all of the applicable state-affecting upgrades. Signed-off-by: meows <[email protected]>
Feature tests test the EIP-based feature interface compatibilities across supported client configurations. Consensus tests prove congruence between consensus protocols. Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a consensus issue affecting Clique-based chain configurations.
Tests are introduced to prove cross-consensus compatibility for cross-client state tests.
Fixes #120