improve cross-consensus engine tests and interface implementations #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables were renamed in #106 This one was accidentally omitted. Signed-off-by: meows <[email protected]>
meowsbits
force-pushed
the
fix/make-file-coregeth-test-cmd
branch
from
b271861 to
874436e
Compare
…tions unset alternate consensus engines on set This fixes/causes configurator implementations to actually have only one engine set at any given time. Tests for cross-consensus compatibility are extended to all Fork configurations, switching any from Clique to Ethash, and vice versa. Signed-off-by: meows <[email protected]>
meowsbits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestStateof the test/ suite.