-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC/messnet 1 #182
Closed
Closed
RC/messnet 1 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts the reorganization data-aggregation logic from its execution logic. This will allow observation and arbitration using the proposed reorganization data without necessarily acting on it. Signed-off-by: meows <[email protected]>
This is only really an optimization, paving the way for installing additional reorg arbitration. Signed-off-by: meows <[email protected]>
Implements spec documented here: https://github.com/etclabscore/artificial-finality/blob/master/MESS.md MESS is an artificial finality mechanism endowing the blockchain's current segment with so-called 'gravity' by requiring a competing chain to satisfy an exponentially increasing relative total difficulty. Note that is change causes several tests with reorgs to fail. This will be addressed by implementing the feature as a chain configuration option. Signed-off-by: meows <[email protected]>
…1355 configuration interface implementation Implement ECBP11355 interface methods for supporting chain configuration types. Signed-off-by: meows <[email protected]>
This meter was added to ethereum/go-ethereum after my original refactor was done, so my update missed it, and it was caught by the deadcode linter. Add it, fix it. Signed-off-by: meows <[email protected]>
- local head staleness - min peers These are mechanisms designed to provide sane safeguard heuristics for nodes to enable/disable artificial finality features within reason. Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
This is intended to keep upstream merges streamlined by moving 'custom' logic to a non-colliding space. Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Should help with debugging if it comes to that. 4 decimals chosen because that matches the current base value precision: 1.0001 Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Forgot to actually plug this in. Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
One order of magnitude greater than the exponent's base of 1.0001. Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
The sinusoidal function seems the most desirable. This changeset also includes a shallow threshold of 3 blocks, returning positive acceptance with difficulty is equivalent. This is intended to sidestep negative impacts on uncle rates. Signed-off-by: meows <[email protected]>
…ame shallow Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
…ealer Signed-off-by: meows <[email protected]>
Without this, the only fake part of --fakepow is the VERIFICATION of blocks, not the sealing. This makes the sealer fake with --fakepow as well. Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
These are assumed to not be consensus-discriminating hard fork configs. Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
…ceptance Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
This is just a double-extra safety feature that will allow operators to disable the feature if necessary. Signed-off-by: meows <[email protected]>
…m,multigeth,parity: s/11355/1100/g Rel ethereumclassic/ECIPs#373 (review) Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
This also introduces the no-compare for function Compatible, since we don't want to necessitate equivalence there either. Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Conflicts: go.mod go.sum
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Conflicts: eth/api.go internal/web3ext/web3ext.go
Signed-off-by: meows <[email protected]>
Signed-off-by: meows <[email protected]>
Closing since testing with MESSNet is completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Candidate branch for MESS-available features and
--messnet
specific configurations and features.master
at eb8bbb0feat/mess
(ECBP-1100: MESS implementation #181)feat/fakepow-delaysealer
(Feat/fakepow delaysealer #180)--messnet
(62f29e8)Naming strategy:
v1.11.14-rc-messnet-<number>
for tagged "stable" RC versions that we'll roll out for MessNet testing.v1.11.14-rc-messnet-<number>+
for untagged "unstable" versions that will represent development iterations between MessNet releases, if necessary.Unless thinking changes, this branch won't be merged to master; we'll handle merging the composite features to master, which may or may not include the
fakepow-fakedelay
Poisson sealer and the MessNet configs and/or flag.