ecip 1099 #186
Merged
ecip 1099 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing im unsure on is how much we want to ethash > etchash. imo anything additional is primarily cosmetic, and adds burden to future maintenance. i.e renaming the consensus engine. |
|
Yea, wherever (in the code) the name doesn't serve an important and functional distinction, I would use |
meowsbits
reviewed
Sep 22, 2020
meowsbits
reviewed
Sep 22, 2020
meowsbits
reviewed
Sep 22, 2020
meowsbits
reviewed
Sep 22, 2020
iquidus
commented
Sep 24, 2020
iquidus
commented
Sep 25, 2020
meowsbits
reviewed
Sep 28, 2020
meowsbits
reviewed
Sep 28, 2020
|
|
||
| case (ctx.GlobalBool(ClassicFlag.Name) || ctx.GlobalBool(MordorFlag.Name)) && cfg.Ethash.DatasetDir == eth.DefaultConfig.Ethash.DatasetDir: | ||
| // ECIP-1099 is set, use etchash dir for DAGs instead | ||
| home := os.Getenv("HOME") |
There was a problem hiding this comment.
This copy-pasta will be able to be replaced with an exported HomeDir function, coming from https://github.com/etclabscore/core-geth/pull/191/files#diff-fdd625b1499a66d8f93635113abdd5e0R202.
🎉
|
The results of a benchmark comparison on the |
…tests Signed-off-by: meows <[email protected]>
meowsbits
force-pushed
the
dev/ecip-1099
branch
from
0bda5d7 to
107dfff
Compare
meowsbits
approved these changes
Sep 30, 2020
|
Need to fix the fork tests |
96fc7ee removed the activation, for now. This commit fixes the tests for that. Signed-off-by: meows <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ECIP-1099 (Calibrate Epoch Duration) specified at ethereumclassic/ECIPs#367