Merge/foundation release/1.11 rm other client configs #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes/genesisT,params/types/multigeth,tests: remove multigeth data type Multi-geth has been disused and unimproved for many a moon now. Though her roots will be with us always, now her name fades from the history books. Thanks for the good idea. Date: 2023-04-11 13:34:58-07:00 Signed-off-by: meows <[email protected]>
…onfp/internal,params/confp/tconvert,params/types/parity,params/types/tests,tests: remove openethereum (nee parity) data type The OpenEthereum (nee Parity) client is disused and maintenance for it continues to to outweight the benefits. It too shall go the way of the dodo. Date: 2023-04-11 14:32:57-07:00 Signed-off-by: meows <[email protected]>
…aleth,pythereum data types Like the previous two commits, this removes the data type of disused/poorly supported clients. Not much interesting here since these were only marginally supported in the first place. Date: 2023-04-11 15:19:20-07:00 Signed-off-by: meows <[email protected]>
…ypes/genesisT: run 'go generate ./...' Date: 2023-04-11 15:40:03-07:00 Signed-off-by: meows <[email protected]>
meowsbits
force-pushed
the
merge/foundation-release/1.11-rm-other-client-configs
branch
from
8467b64 to
c60b940
Compare
This only re-establishes the writes to this file that are not supposed to happen because its a generated file. Date: 2023-04-11 16:16:48-07:00 Signed-off-by: meows <[email protected]>
meowsbits
commented
Apr 12, 2023
core/types/gen_receipt_json.go
Outdated
| @@ -25,7 +25,7 @@ func (r Receipt) MarshalJSON() ([]byte, error) { | |||
| TxHash common.Hash `json:"transactionHash" gencodec:"required"` | |||
| ContractAddress common.Address `json:"contractAddress"` | |||
| GasUsed hexutil.Uint64 `json:"gasUsed" gencodec:"required"` | |||
| EffectiveGasPrice *hexutil.Big `json:"effectiveGasPrice,omitempty"` | |||
| EffectiveGasPrice *big.Int `json:"effectiveGasPrice"` | |||
There was a problem hiding this comment.
This change adds a struct field EffectiveGasPrice in types.Receipt. The field is present
in RPC responses, but not in the Go struct, and thus can't easily be accessed via ethclient
This change is related to an error I'm seeing locally at TestT8n, where the effectiveGasPrice: null pair is present but unexpected.
This branch has recently done a go generate ./... command.
Simply adding ,omitempty to the gen_receipt MarshalJSON method will fix it, but seems again like there might be a better way than editing the generated file... but in other Receipt contexts it seems we're identical to upstream.
This is ugly, but I don't see any other way yet, and it doesn't seem that different from what's going on upstream. Date: 2023-04-12 06:54:18-07:00 Signed-off-by: meows <[email protected]>
The last commit edits a generated file. This patch registers this last commit to be reverted before the go-generate CI test is run. Date: 2023-04-13 07:52:52-07:00 Signed-off-by: meows <[email protected]>
|
Heads up on 07eff87; the test was passing for unknown reasons, but this should hopefully prevent it from failing for unknown reasons, too. Resolving #535 (review). |
meowsbits
deleted the
merge/foundation-release/1.11-rm-other-client-configs
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving a TODO at this comment.
Merge base: #531
This PR proposed removing support for configuration data types of MultiGeth, OpenEthereum/Parity, Aleth, and Pythereum. Only the first two were well supported at core-geth anyways, but all have become disused in some way and supporting configuration interchange with them just doesn't make that much sense anymore. For example, since about Istanbul new EIPs have not been supported, so the data type was basically a stand-in anyways.