Add a Rerun button #158
Closed
Add a Rerun button #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonherrmann
reviewed
Sep 2, 2018
| var regex1 = RegExp(/\(\d+\)$/); | ||
| var regex2 = RegExp(/\d+/); | ||
| if(regex1.test(label)){ | ||
| var cadenaIntentos = regex1.exec(label); |
There was a problem hiding this comment.
It's good that the number of rerun tests is appended to the label.
Please translate the variable names into english (violates QC 9)
There was a problem hiding this comment.
Fixed in guadaltel@51881ee
src/main/webapp/layout.html
Outdated
| @@ -58,7 +58,7 @@ <h1 th:if="${T(de.interactive_instruments.etf.webapp.helpers.View).brandingText | |||
| <!--/* Footer */--> | |||
| <div tiles:fragment="footer"> | |||
| <div data-role="footer" data-position="fixed"> | |||
| <h1>ETF WebApp <span th:text="${T(de.interactive_instruments.etf.webapp.helpers.View).version}">X.Y.Z</span> © 2017-2018 European Union, interactive instruments GmbH</h1> | |||
| <h1>ETF WebApp <span th:text="${T(de.interactive_instruments.etf.webapp.helpers.View).version}">X.Y.Z</span> © 2017-2018 European Union</h1> | |||
There was a problem hiding this comment.
'interactive instruments GmbH' is missing here
There was a problem hiding this comment.
Fixed in guadaltel@51881ee
carlospzurita
pushed a commit
to guadaltel/etf-webapp
that referenced
this pull request
Sep 11, 2018
carlospzurita
pushed a commit
to guadaltel/etf-webapp
that referenced
this pull request
Oct 23, 2018
This was referenced Dec 18, 2018
Update to head fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.