Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP 34 - open log in new tab #192

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Conversation

carlospzurita
Copy link
Contributor

Fixing for etf-validator/governance#34
We added a target="_blank" on the test-reports.html to make the log create a new tab on the browser

@jonherrmann jonherrmann self-requested a review February 15, 2019 09:50
@jonherrmann jonherrmann changed the title EIP 34 EIP 34 - open log in new tab Apr 3, 2019
@jonherrmann jonherrmann merged commit 2db6282 into etf-validator:next Apr 3, 2019
@carlospzurita carlospzurita deleted the EIP-34 branch May 15, 2019 16:03
@jonherrmann jonherrmann added the PR: ignore used to filter rejected / reopened Pull Requests label Jul 31, 2020
@jonherrmann
Copy link
Collaborator

jonherrmann commented Jul 31, 2020

Ignoring the PRs code for release 2.1.0 in favour of target="<%= testRun.id %>".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ignore used to filter rejected / reopened Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants