No compile enhancement #1507
Merged
No compile enhancement #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems useful - sometimes when I have too many dependencies the logic for which contracts to recompile bugs out, and it's annoying to wait for it to run every single time. |
|
Marked as ready, gonna merge - CI has been broken for a while and I'll deal with any linting issues before making a realease |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added an optional argument to both load functions in project/main.py. I also added an optional argument, --no-compile, to cli/console and added some tests. I still have to add the handling within cli/console and make sure a compile already exists. I am having issues with pre-commit and tox -e lint in my environment so wanted to submit this draft PR.
Related issue: #1096
How I did it
How to verify it
Checklist