Skip to content

Commit

Permalink
installDeps.sh: do not modify package.json when installing dependencies
Browse files Browse the repository at this point in the history
installDeps.sh's only side effect should be to actually install dependencies
according to a configuration file, and not to modify it.

Adding --no-save to the npm command line forces npm to have a read only access
to package.json.

Old npm versions seem to support --no-XXX style flags even if not documented
(see npm/npm#14285 (comment))

Tested with npm 3.5.2 and 6.1.0

Fixes #3396
  • Loading branch information
muxator committed Jul 14, 2018
1 parent 24b5817 commit c4918ef
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bin/installDeps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ echo "Ensure that all dependencies are up to date... If this is the first time
cd node_modules
[ -e ep_etherpad-lite ] || ln -s ../src ep_etherpad-lite
cd ep_etherpad-lite
npm install --loglevel warn
npm install --no-save --loglevel warn
) || {
rm -rf node_modules
exit 1
Expand Down

0 comments on commit c4918ef

Please sign in to comment.