-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toolbar on mobile #3703
Fix toolbar on mobile #3703
Conversation
f369b8a
to
bf5a48f
Compare
There are some remaining issues with the default skin (Colibris).
@pkrasicki, from your screenshot, I think you tested on the old skin. Is it so? If so, it would be good to find a way that is compatible with both old & new skin. Let's discuss on #3697. |
I tested with the default settings and current develop branch. I didn't know there was any other skin included by default. Can you tell me more? Where are the files located for that other skin? I also tested on Firefox, but a bit older version (ESR). |
@muxator I can't reproduce your issue with default settings, but there is some strange behaviour in responsive design mode that I would have to look into. |
Hi @pkrasicki, support for multiple skins was introduced in Etherpad 1.7.5, along with an experimental skin (Colibris, contributed by the community). As starting point, have a look at the changelog for 1.7.5. A skin can be selected with the Colibris became the default for new installations in 1.8.0 (i.e., it was put in If your install is not recent, chances are that your |
Partially fixes ether#3697 Makes the toolbar more responsive.
bf5a48f
to
0c71683
Compare
We are probably going to merge #3709 instead, due to considerations regarding what happens with more than two rows of toolbars. Thanks @pkrasicki for this proposal! |
Fixes #3697