Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toolbar on mobile #3703

Closed
wants to merge 1 commit into from
Closed

Conversation

pkrasicki
Copy link

@pkrasicki pkrasicki commented Mar 6, 2020

Fixes #3697

etherpad mobile toolbar fix

@pkrasicki pkrasicki force-pushed the mobile-toolbar-fix branch from f369b8a to bf5a48f Compare March 6, 2020 08:28
@muxator
Copy link
Contributor

muxator commented Mar 12, 2020

There are some remaining issues with the default skin (Colibris).
This is what I see when I resize my Firefox 74 window while running Etherpad bb868be with this modification on top:

  1. when the window is large everything is ok:
    01

  2. narrowing the window, some icons disappear (this is the original intended behaviour by @seballot, that this patch wanted to change, and we are probably going to change in a different way to solve Default skin needs polish #3697):
    02

  3. after narrowing some more pixels, @pkrasicki's patch kicks in, but it's too late :), and I guess some alignments are off:
    03

@pkrasicki, from your screenshot, I think you tested on the old skin. Is it so? If so, it would be good to find a way that is compatible with both old & new skin. Let's discuss on #3697.

@pkrasicki
Copy link
Author

pkrasicki commented Mar 12, 2020

I tested with the default settings and current develop branch. I didn't know there was any other skin included by default. Can you tell me more? Where are the files located for that other skin?

I also tested on Firefox, but a bit older version (ESR).

@pkrasicki
Copy link
Author

pkrasicki commented Mar 12, 2020

Or I can abandon this if #3709 is going to be merged.

we are probably going to change in a different way to solve #3697

What solution do you think would be better for this?

@pkrasicki
Copy link
Author

pkrasicki commented Mar 12, 2020

@muxator I can't reproduce your issue with default settings, but there is some strange behaviour in responsive design mode that I would have to look into.

etherpad mobile toolbar fix 2

@muxator
Copy link
Contributor

muxator commented Mar 12, 2020

I didn't know there was any other skin included by default. Can you tell me more? Where are the files located for that other skin?

Hi @pkrasicki, support for multiple skins was introduced in Etherpad 1.7.5, along with an experimental skin (Colibris, contributed by the community). As starting point, have a look at the changelog for 1.7.5.

A skin can be selected with the skinName configuration parameter in settings.json. For a description have a look at the relevant lines in settings.json.template.

Colibris became the default for new installations in 1.8.0 (i.e., it was put in settings.json.template, from wich settings.json is copied when a new instance starts for the first time).

If your install is not recent, chances are that your settings.json does not contain the skinName parameter, and thus your setup continues to run with the original appearance.

Partially fixes ether#3697

Makes the toolbar more responsive.
@pkrasicki pkrasicki force-pushed the mobile-toolbar-fix branch from bf5a48f to 0c71683 Compare March 13, 2020 11:19
@pkrasicki
Copy link
Author

Fixed. It works with both themes now.

etherpad-toolbar-mobile-no-skin

etherpad-toolbar-mobile-colibris

@pkrasicki pkrasicki closed this Mar 13, 2020
@muxator
Copy link
Contributor

muxator commented Mar 14, 2020

We are probably going to merge #3709 instead, due to considerations regarding what happens with more than two rows of toolbars.

Thanks @pkrasicki for this proposal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default skin needs polish
2 participants