Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viem: abigen from optimism repo snapshots #619

Merged
merged 11 commits into from
Jan 17, 2025
Merged

viem: abigen from optimism repo snapshots #619

merged 11 commits into from
Jan 17, 2025

Conversation

hamdiallam
Copy link
Contributor

@hamdiallam hamdiallam commented Jan 16, 2025 •
edited
Loading

Introduce submodule dependency on https://github.com/ethereum-optimism/optimism repo

  • update abigen script to generate abi from the snapshots in the repo.
  • script commands consistent with chaingen
  • do not export the abis -- the actions should be used by users

@hamdiallam Graphite App
Copy link
Contributor Author

hamdiallam commented Jan 16, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hamdiallam hamdiallam mentioned this pull request Jan 16, 2025
Merged
@hamdiallam hamdiallam marked this pull request as ready for review January 16, 2025 18:52
@hamdiallam hamdiallam requested a review from a team as a code owner January 16, 2025 18:52
@hamdiallam hamdiallam requested review from mayanksayshi and removed request for a team January 16, 2025 18:52
@hamdiallam hamdiallam changed the title abigen viem: abigen from optimism repo snapshots Jan 16, 2025
@hamdiallam hamdiallam force-pushed the optimism.abigen branch 3 times, most recently from 4dcb50d to 505ea9b Compare January 16, 2025 23:24
Base automatically changed from superchain_registry_bindings to main January 16, 2025 23:28
@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for storybook-component-library canceled.

Name Link
🔨 Latest commit 5929de6
🔍 Latest deploy log https://app.netlify.com/sites/storybook-component-library/deploys/6789a081f6acee0008bb0ac6

@hamdiallam hamdiallam mentioned this pull request Jan 17, 2025
Merged
@hamdiallam hamdiallam merged commit bba9176 into main Jan 17, 2025
10 checks passed
@hamdiallam hamdiallam deleted the optimism.abigen branch January 17, 2025 00:17
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremarkley tremarkley tremarkley approved these changes

@mayanksayshi mayanksayshi Awaiting requested review from mayanksayshi mayanksayshi is a code owner automatically assigned from ethereum-optimism/ecosystem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamdiallam @tremarkley