have batcher submit appropriate cancellation transactions when mempool is blocked

[roberto-bayardo]

Description

Extend batcher to submit appropriate cancellation transactions when the mempool is blocked by a transaction of incompatible type.

Also makes the txmgr use the geth-defined AlreadyReservedErr instead of redefining it, now that op-geth has caught up to the commit that exposes it.

Tests

Extended the E2E tests to submit incompatible pending transactions to the txpool to confirm the new functionality appropriately clears them.

Metadata

• Fixes #[ethereum-optimism/protocol-quest/issues/102]

[axelKingsley]

This solution manages an enumerated State of the Transaction Pool, specifically whether it is unblocked, blocked, or pending(cancel). It does this by detecting a specific error type which sets the state to Blocked. When blocked it sends and empty batch with a special ID, and progresses to Pending. When in Pending, it optimistically advances back to Unblocked.

I left some comments to better understand the behavior and suggest some potential simplifications. This solution seems reasonable given the scope of changes, though it'd be nice to have a more comprehensive handling as part of the architecture at some point down the road.

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.58%. Comparing base (f5221f4) to head (dcfc6c3).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #10941   +/-   ##
========================================
  Coverage    62.58%   62.58%           
========================================
  Files           21       21           
  Lines         1935     1935           
  Branches        71       71           
========================================
  Hits          1211     1211           
  Misses         687      687           
  Partials        37       37           

Flag	Coverage Δ
cannon-go-tests	80.21% <ø> (ø)
chain-mon-tests	27.14% <ø> (ø)
sdk-tests	16.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[roberto-bayardo]

I have rebased the PR to clear the conflicts.

[sebastianst]

Looks good! Some minor improvement suggestions.