Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannon: Add more sync tests #12949

Merged
merged 22 commits into from
Nov 21, 2024
Merged

cannon: Add more sync tests #12949

merged 22 commits into from
Nov 21, 2024

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Nov 18, 2024 •
edited
Loading

Description

Port more Go sync tests to increase test coverage over concurrency primitives:

  • Add a shared TestRunner utility that can replace testing.T in the Go tests being ported.
  • Copy over sync tests from the Go repo (named <orig_file>_copy.go), add a license header, and replace the testing.T dependency in each individual tests with the TestRunner util.

Builds on: #12771

Testing

  • Port more unit tests from the Go repo's sync package.
  • Add some simple tests for the new TestRunner utility to make sure we'll get a non-zero exit when a test fails.

Metadata

Fixes #12162

mbaxter added 22 commits November 18, 2024 10:49
@mbaxter
cannon: Port go map tests
5f9ab85
@mbaxter
cannon: Port pool_test.go
fdfbafd
@mbaxter
cannon: Port a few more mutex tests
5f4810e
@mbaxter
cannon: Port waitgroup_test.go
ba65989
@mbaxter
cannon: Port oncefunc_test.go (in progress)
6114c4d
@mbaxter
cannon: Port atomic_test.go (in progress)
a046c2f
@mbaxter
cannon: Port value_test.go (in progress)
28516a0
@mbaxter
cannon: Fix atomic tests by using a test mock
784f09c
@mbaxter
cannon: Fix test fail behavior
11687db
@mbaxter
cannon: Move test util to a shared module
cf4c8db
@mbaxter
cannon: Use common testutil throughout
8d2dc9c
@mbaxter
cannon: Fix failing tests
cc798bf
@mbaxter
cannon: Add sanity check test program for test runner utils
d6a88f0
@mbaxter
cannon: Add more util tests, fix step counts
97980c8
@mbaxter
cannon: Rename test util method
3a849c1
@mbaxter
cannon: Fix panic, error handling in testutil
249c059
@mbaxter
cannon: Dedupe test running code
b75e13e
@mbaxter
cannon: Simplify testutil interface
4bf57cb
@mbaxter
cannon: Mark mt tests as slow
9eb0f8a
@mbaxter
cannon: Cut debugging code from test
825febc
@mbaxter
cannon: Validate gc complete output
7e3fbbb
@mbaxter
cannon: Synchronize access to bool values
3745516
@mbaxter
Copy link
Contributor Author

mbaxter commented Nov 18, 2024

/ci authorize 3745516

2 similar comments
@mbaxter
Copy link
Contributor Author

mbaxter commented Nov 18, 2024

/ci authorize 3745516

@mslipper
Copy link
Collaborator

/ci authorize 3745516

@mbaxter mbaxter requested a review from Inphi November 18, 2024 18:54
@mbaxter mbaxter marked this pull request as ready for review November 18, 2024 18:54
@mbaxter mbaxter requested review from a team as code owners November 18, 2024 18:55
@Inphi
Copy link
Contributor

Inphi commented Nov 21, 2024

@mbaxter merging now to lock down audit commit.

@Inphi Inphi added this pull request to the merge queue Nov 21, 2024
Merged via the queue into ethereum-optimism:develop with commit cc2715c Nov 21, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inphi Inphi Inphi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MTCannon: Add more test coverage over Go concurrency primitives
3 participants
@mbaxter @mslipper @Inphi