-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-deployer: add intent-config-type #12970
Conversation
a7d91eb
to
9d0e556
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few issues I'd like to address before merge. Happy to pair next week to resolve them.
fc440e4
to
3af7850
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12970 +/- ##
===========================================
- Coverage 44.46% 42.81% -1.66%
===========================================
Files 798 743 -55
Lines 71682 67175 -4507
===========================================
- Hits 31876 28762 -3114
+ Misses 37219 35990 -1229
+ Partials 2587 2423 -164
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Creates the concept of
intent-config-type
. Based on the selection, some fields are auto-populated and others are expected to be populated by the user prior to runningop-deployer apply
. Valid options are:test
used by current test suite, deterministically generates addresses/keys used in testingstandard
(default, uses standard values as defined in superchain-registry where possible)custom
requires all params to be populated by user, errors duringapply
if any don't get setstrict
same as "standard", but sets additional paramsstandard-overrides
strict-overrides
Design Details
op-deployer init
intent.SetInitValues
: generates initial intent (with many empty fields)op-deployer apply
op-deployer apply
init
intent.ValidateIntentConfigType
: validates that all fields have been populated, and that values meet expectation (e.g. standard values are used ifintent-config-type=standard
Open questions
Which fields should the
standard-overrides
/strict-overrides
settings allow to be overridden? The way this is currently implemented:standard-overrides
:op-deployer init
: sets intent.toml standard valuesop-deployer apply
: validates that all values are populated (i.e. non zero value) but doesn't require specific valuesstrict-overrides
:op-deployer init
: sets intent.toml strict valuesop-deployer apply
: validates that all values are populated (i.e. non zero value) but doesn't require specific valuesMeta
Closes https://github.com/ethereum-optimism/platforms-team/issues/305