Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: add test for deployConfig overrides #12985

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

vdamle
Copy link
Contributor

@vdamle vdamle commented Nov 19, 2024

Test hard fork offset overrides

Description

Tests the input format to override fields in deploy config (hard fork upgrade schedule) and expected output.

Tests

See above.

Additional context

When attempting to use Kurtosis to setup a chain with overrides for L2 hard fork blocks, I wrote this test to figure out how to pass the overrides from here

Metadata

None

Test hard fork offset overrides
@vdamle vdamle requested a review from mslipper November 19, 2024 19:56
@vdamle vdamle requested a review from a team as a code owner November 19, 2024 19:56
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK for now, but in the future I'd love a more comprehensive test for deploy config overrides since there are many other cases where we need this functionality.

@mslipper mslipper added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit b0427be Nov 20, 2024
52 checks passed
@mslipper mslipper deleted the op-deployer-ut branch November 20, 2024 22:25
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (b824f9b) to head (62b476a).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12985      +/-   ##
===========================================
- Coverage    68.78%   66.77%   -2.02%     
===========================================
  Files           56       56              
  Lines         4665     4665              
===========================================
- Hits          3209     3115      -94     
- Misses        1274     1378     +104     
+ Partials       182      172      -10     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants