Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: clean up primary justfile #12997

Merged
merged 2 commits into from
Nov 27, 2024
Merged

maint: clean up primary justfile #12997

merged 2 commits into from
Nov 27, 2024

Conversation

smartcontracts
Copy link
Contributor

Various things in the primary justfile weren't particularly legible, particularly around installing tooling versions. Cleans up the primary justfile so that everything has comments and the process for installing tooling is unified.

@smartcontracts smartcontracts requested review from a team as code owners November 20, 2024 10:28
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (406e92e) to head (21dea11).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12997      +/-   ##
===========================================
- Coverage    68.78%   66.77%   -2.02%     
===========================================
  Files           56       56              
  Lines         4665     4665              
===========================================
- Hits          3209     3115      -94     
- Misses        1274     1378     +104     
+ Partials       182      172      -10     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

---- 🚨 Try these New Features:

@smartcontracts smartcontracts force-pushed the sc/clean-justfile-1 branch 4 times, most recently from 981a706 to 43a598a Compare November 20, 2024 12:52
Various things in the primary justfile weren't particularly
legible, particularly around installing tooling versions. Cleans
up the primary justfile so that everything has comments and the
process for installing tooling is unified.
@mslipper mslipper enabled auto-merge November 27, 2024 23:32
@mslipper mslipper added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit 16a5d61 Nov 27, 2024
42 checks passed
@mslipper mslipper deleted the sc/clean-justfile-1 branch November 27, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants