ctb: Fix Holocene upgrade script #13015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
approved these changes
Nov 22, 2024
packages/contracts-bedrock/scripts/upgrades/holocene/scripts/main.sh
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/upgrades/holocene/scripts/main.sh
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/upgrades/holocene/.env.example
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
* ctb: Fix Holocene upgrade script * improve README * pass deploy-config as parameter to just run, other improvements * remove commented-out variables
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mds1
reviewed
Nov 22, 2024
|
The issue breaking the merge queue here has been fixed - should be good to merge once the above convo is resolved. |
geoknee
pushed a commit
that referenced
this pull request
Nov 25, 2024
* ctb: Fix Holocene upgrade script * improve README * pass deploy-config as parameter to just run, other improvements * remove commented-out variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of fixes to the Holocene upgrade script.
rc.2.''fromsed -i ''invocations - this is a MacOS quirk, but doesn't work in a Linux Docker env.deploy-config.jsonwas made a parameter tojust run.just run. Defaults tooutput/.