Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Legacy Contract tests #13022

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

AmadiMichael
Copy link
Member

@AmadiMichael AmadiMichael commented Nov 21, 2024

  • DeployerWhitelist

@AmadiMichael AmadiMichael requested a review from a team as a code owner November 21, 2024 21:59
@AmadiMichael AmadiMichael requested review from maurelian and smartcontracts and removed request for maurelian November 21, 2024 21:59
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (cc2715c) to head (f8d17df).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13022      +/-   ##
===========================================
- Coverage    68.78%   66.77%   -2.02%     
===========================================
  Files           56       56              
  Lines         4665     4665              
===========================================
- Hits          3209     3115      -94     
- Misses        1274     1378     +104     
+ Partials       182      172      -10     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

---- 🚨 Try these New Features:

@smartcontracts smartcontracts added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit 8f5c20e Nov 21, 2024
45 checks passed
@smartcontracts smartcontracts deleted the sc/improve-legacy-tests-cov branch November 21, 2024 22:35
mslipper added a commit that referenced this pull request Nov 22, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 22, 2024
@smartcontracts smartcontracts restored the sc/improve-legacy-tests-cov branch November 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants