fix(ci): contracts test names check failures #13034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lint-forge-tests-check-no-build was causing issues in CI because it was running as part of contracts-bedrock-checks which depends on contracts-bedrock-build. contracts-bedrock-build builds the contract files EXCEPT for tests whenever contracts-bedrock has changed. This means that contracts-bedrock-build would not build any test files and therefore lint-forge-tests-check-no-build would not find any test files to check and the job would do nothing. However, when contracts-bedrock is NOT changed, the build job gets the full set of artifacts INCLUDING test artifacts from the cache. This would trigger the full check to actually be run and it would properly fail. This PR moves that particular check into contracts-bedrock-tests so that it's guaranteed to have all of the compiled contracts.
mslipper
approved these changes
Nov 22, 2024
|
nice catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint-forge-tests-check-no-build was causing issues in CI because it was running as part of contracts-bedrock-checks which depends on contracts-bedrock-build. contracts-bedrock-build builds the contract files EXCEPT for tests whenever contracts-bedrock has changed. This means that contracts-bedrock-build would not build any test files and therefore lint-forge-tests-check-no-build would not find any test files to check and the job would do nothing. However, when contracts-bedrock is NOT changed, the build job gets the full set of artifacts INCLUDING test artifacts from the cache. This would trigger the full check to actually be run and it would properly fail.
This PR moves that particular check into contracts-bedrock-tests so that it's guaranteed to have all of the compiled contracts.