ci: Convert all Go tests into a single job #13046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13046 +/- ##
===========================================
- Coverage 68.78% 66.77% -2.02%
===========================================
Files 56 56
Lines 4665 4665
===========================================
- Hits 3209 3115 -94
- Misses 1274 1378 +104
+ Partials 182 172 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Takes all the go-e2e and go-test jobs and combines them into one single super-job. This has the following benefits: 1. We can centralize all config for Go tests in one place and simplify our CI pipeline. 2. It leaves parallelism up to the Go runtime, which is more efficient. 4. It makes our test reporting more accurate. As part of this PR, I also: 1. Created a new resource class just for Go tests. It runs on the large Latitude runner, but limits the number of parallel go test jobs to 3 to prevent resource starvation. 2. Enabled test retries on `gotestsum`. This should reduce the number of flakes we see from the Go tests by retrying them up to 2 times in the event that they fail. Failures are still captured by the test reporting, so we can address them.
mslipper
force-pushed
the
feat/single-go-job
branch
from
5facdff to
dce9170
Compare
sigma
reviewed
Nov 25, 2024
sigma
approved these changes
Nov 25, 2024
Inphi
reviewed
Nov 25, 2024
| # constraint that gotestsum does not currently (nor likely will) accept files from different packages when building. | ||
| JUNIT_FILE=../tmp/test-results/<<parameters.module>>_<<parameters.target>>.xml JSON_LOG_FILE=../tmp/testlogs/test.log make <<parameters.target>> | ||
| working_directory: <<parameters.module>> | ||
| export OP_E2E_SKIP_SLOW_TEST=true |
There was a problem hiding this comment.
We've lost coverage for slow running tests. Working on a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes all the go-e2e and go-test jobs and combines them into one single super-job. This has the following benefits:
As part of this PR, I also:
gotestsum. This should reduce the number of flakes we see from the Go tests by retrying them up to 2 times in the event that they fail. Failures are still captured by the test reporting, so we can address them.