Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Add a proxy to handle RPC failures #13068

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

Anvil is very finnicky when it comes to RPC responses. It'll blow up if it encounters any HTTP error, and does not support retries. This PR adds a locally-hosted proxy which sits between Anvil and the fork RPC source and handles retries automatically.

Anvil is very finnicky when it comes to RPC responses. It'll blow up if it encounters any HTTP error, and does not support retries. This PR adds a locally-hosted proxy which sits between Anvil and the fork RPC source and handles retries automatically.
@mslipper mslipper requested review from a team as code owners November 25, 2024 19:44
@mslipper mslipper requested a review from geoknee November 25, 2024 19:44
Copy link
Contributor

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea seems sound to me. I didn't yet have the time to review the implementation in a lot of detail... Approving with a couple of Qs so we can get CI unblocked.

@mslipper mslipper added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@mslipper mslipper added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit 8f69ac7 Nov 25, 2024
41 checks passed
@mslipper mslipper deleted the feat/retry-proxy branch November 25, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants