op-deployer: Simplify and fix bootstrap disputegame #13094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
force-pushed
the
aj/dispute-game-args
branch
from
864b814 to
314e96e
Compare
mslipper
reviewed
Nov 26, 2024
mslipper
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
bootstrap disputegamesubcommand was ignoring most of the CLI arguments - fix it so they are actually passed through to the config.Also simplify it to only deploy the dispute game contract and use the existing vm and preimage oracle. Hard forks typically need a new FaultDisputeGame deployment, but reuse the existing vm and preimage oracle so this is a more useful target.
Tests
Updated unit tests to cover setting the config from the CLI.