Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore asterisc bytecode, vendor #13104

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

smartcontracts
Copy link
Contributor

Restores the correct asterisc RISCV bytecode, moves the contract to the vendor folder, and changes CI so that it performs the check on the asterisc bytecode when attempting to merge into develop.

@clabby
Copy link
Member

clabby commented Nov 26, 2024

Needs snapshots

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.31%. Comparing base (4f8e9b5) to head (489240f).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13104      +/-   ##
===========================================
- Coverage    44.44%   44.31%   -0.14%     
===========================================
  Files          798      798              
  Lines        71668    71668              
===========================================
- Hits         31855    31759      -96     
- Misses       37225    37331     +106     
+ Partials      2588     2578      -10     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.72% <ø> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

Restores the correct asterisc RISCV bytecode, moves the contract
to the vendor folder, and changes CI so that it performs the check
on the asterisc bytecode when attempting to merge into develop.
@AmadiMichael
Copy link
Member

AmadiMichael commented Nov 26, 2024

Can this contract be made to use ^0.8.0 or 0.8.25?

@smartcontracts smartcontracts added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 9200bff Nov 26, 2024
42 checks passed
@smartcontracts smartcontracts deleted the sc/asterisc-fixup branch November 26, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants